Fix threshold retrieve in tx-service mode #410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the safe-cli is running on ts-service mode the threshold was wrongly updated to the new value during a
change_threshold
command call.The issue was that the function
prepare_and_execute_transaction
is overwritten by theSafeTxOperator
class with the difference that instead execute the transaction in blockchain, the overwritten function POST the transaction to the Safe Transaction Service without execute it.Proposal solution
Update from blockchain the threshold value.
Related issue
Closes #323